Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kind test make target to use cluster name #4706

Merged
merged 2 commits into from
Nov 28, 2023
Merged

kind test make target to use cluster name #4706

merged 2 commits into from
Nov 28, 2023

Conversation

pdabelf5
Copy link
Collaborator

Proposed changes

Fix issues introduced in last PR where the kind cluster name was made dynamic in make targets.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner November 27, 2023 17:07
@github-actions github-actions bot added the tests Pull requests that update tests label Nov 27, 2023
jjngx
jjngx approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jjngx jjngx requested a review from a team November 27, 2023 18:20
@pdabelf5 pdabelf5 enabled auto-merge (squash) November 27, 2023 20:20
@pdabelf5 pdabelf5 self-assigned this Nov 27, 2023
auto-merge was automatically disabled November 27, 2023 20:22

Pull Request is not mergeable

@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8da5cf3) 52.06% compared to head (a05e068) 52.09%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4706      +/-   ##
==========================================
+ Coverage   52.06%   52.09%   +0.02%     
==========================================
  Files          59       59              
  Lines       17033    17033              
==========================================
+ Hits         8869     8873       +4     
+ Misses       7864     7862       -2     
+ Partials      300      298       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjngx jjngx merged commit f63c8f7 into main Nov 28, 2023
62 checks passed
@jjngx jjngx deleted the kind-make-test-fix branch November 28, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@jjngx jjngx jjngx approved these changes

Assignees

@pdabelf5 pdabelf5

Labels
tests Pull requests that update tests
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdabelf5 @j1m-ryan @jjngx